rules(license): cap licence findings at :review strategy (neurophone#99 closeout) - #415
Merged
Merged
Conversation
…99 closeout) Owner directive 2026-06-02 forbids automated licence/SPDX edits. Licence findings are flag-only; downstream pipelines must never auto-execute. Triggered by neurophone#99 (auto-PR reverting PMPL -> MPL-2.0 across ~140 files, closed by owner). - lib/rules/cicd_rules.ex: prepend "POLICY -- Manual Only" header to the License Validation section quoting the verbatim owner directive + 5-way classification. Add `license_finding_strategy/0` (always `:review`), `license_finding_severity_cap/1` (always `:warn`), `license_related_finding?/1` (matches the same regex as the gitbot-fleet dispatcher gate), and `owner_license_classification/0` returning the canonical 5-way map. - lib/scorecard_ingestor.ex: SC-010 `License` -> `auto_fixable: false` with remediation text spelling out the 5-way classification. Canonical: ~/.claude/projects/.../feedback_estate_license_policy_umbrella.md Sibling: ~/.claude/projects/.../feedback_no_automated_licence_edits.md Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
hyperpolymath
enabled auto-merge (squash)
June 2, 2026 10:03
🔍 Hypatia Security ScanFindings: 146 issues detected
View findings[
{
"reason": "Action urin 21 JRE\n uses: actions/setup-java@be666c2fcd27 needs attention",
"type": "unpinned_action",
"file": "verify-proofs.yml",
"action": "pin_sha",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in ci.yml",
"type": "missing_timeout_minutes",
"file": "ci.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in ci.yml",
"type": "missing_timeout_minutes",
"file": "ci.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in ci.yml",
"type": "missing_timeout_minutes",
"file": "ci.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in ci.yml",
"type": "missing_timeout_minutes",
"file": "ci.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in ci.yml",
"type": "missing_timeout_minutes",
"file": "ci.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in ci.yml",
"type": "missing_timeout_minutes",
"file": "ci.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in ci.yml",
"type": "missing_timeout_minutes",
"file": "ci.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in ci.yml",
"type": "missing_timeout_minutes",
"file": "ci.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in clusterfuzzlite.yml",
"type": "missing_timeout_minutes",
"file": "clusterfuzzlite.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
}
]Powered by Hypatia Neurosymbolic CI/CD Intelligence |
This was referenced Jun 2, 2026
hyperpolymath
added a commit
that referenced
this pull request
Jun 2, 2026
…tectors (auto-fix wiring) (#422) Continues today's hardening from hypatia#414. Three patterns we hit manually that should be auto-handled next time: Chapel 5 sharp edges, CodeQL cron drift, inherited main-branch debt. License category remains auto_fixable:false per #415. ## Commits - **99b7970** WF024 chapel auto-fix wiring + 4 sub-pattern recipes - Primary WF024 finding now sets `auto_fixable: true` + `recipe_id: chapel-runs-on-pin-22-04` - New `check_chapel_sharp_edges/1` emits 4 recipes: `chapel-manpath-guard`, `chapel-chpl-llvm-export`, `chapel-replace-chpl-about-with-version`, `chapel-find-comm-gasnet` (panic-attack#99) - **2285685** WF025 CodeQL cron-drift detector - Canonical `0 6 1 * *` per standards#286 - Sub-categories route to standards#288 (weekly→monthly) vs standards#324 (non-canonical→canonical) - Shared recipe `codeql-cron-monthly` - **df4f545** BH008 inherited-main-branch-debt detector - Threshold ≥3 open PRs sharing same failing check → flag (`:warn`, `auto_fixable: false`) - Recommends `file_root_fix_pr_on_main` instead of N retries ## Test plan - [x] Each rule has ExUnit coverage under `test/rules/` - [x] Chapel detector test covers all 5 recipe_ids + maximal-bad-workflow case - [x] Cron-drift classifier covers canonical / weekly / non-canonical-monthly / malformed - [x] Inherited-debt fires at 3 PRs, NOT at 2; honors custom threshold; per-PR-unique failures suppressed - [ ] CI to verify `mix test` (local mix env was Elixir 1.14 — couldn't fetch deps); individual files compile clean via `elixirc` 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2 tasks
hyperpolymath
added a commit
that referenced
this pull request
Jun 2, 2026
## Summary Reflect recent rule-catalogue PRs in CHANGELOG and STATE.a2ml: - **#414** — scoped MPL-2.0 carve-outs for upstream-derived submodules - **#415** — SC-010 transitive_dep_drift flipped to auto_fixable:false (manual-only) - **#422** — WF024 chapel_runs_on_drift auto-fix + WF025 cron_schedule_drift + BH008 inherited_main_debt ## Files - CHANGELOG.md — Unreleased entries - .machine_readable/6a2/STATE.a2ml — session-history entry ## Test plan - [x] Markdown renders - [x] No license/SPDX content touched Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/rules/cicd_rules.exLicense Validation section: quotes the verbatim owner directive 2026-06-02 + 5-way classification.license_finding_strategy/0(always:review),license_finding_severity_cap/1(always:warn),license_related_finding?/1(matches the same regex as the gitbot-fleet dispatcher gate),owner_license_classification/0(canonical 5-way map).License→auto_fixable: falsewith remediation text spelling out the 5-way classification.Why
Owner directive 2026-06-02 forbids automated licence/SPDX edits. Triggered by neurophone#99 — an auto-generated PR by the Claude bot reverting PMPL-1.0-or-later → MPL-2.0 across ~140 files, closed by the owner. The fix gates the dispatcher; this PR ensures hypatia (the rule source) never emits an auto-execute licence finding in the first place.
Five-way classification (verbatim):
Test plan
Hypatia.Rules.CicdRules.license_finding_strategy() == :reviewHypatia.Rules.CicdRules.license_finding_severity_cap(:critical) == :warnHypatia.Rules.CicdRules.license_related_finding?("LicenseCompliance") == trueHypatia.Rules.CicdRules.license_related_finding?("MissingSPDX") == trueHypatia.ScorecardIngestorSC-010auto_fixableisfalse.Related: hyperpolymath/gitbot-fleet chore/halt-license-auto-prs, hyperpolymath/standards docs/license-no-auto-policy.